fix(rpc-types): set Uncle as default for BlockTransactions
#98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Evalir
changed the title
rpc-types): set Uncle as default for BlockTransactionsrpc-types): set Uncle as default for BlockTransactions
Evalir
changed the title
rpc-types): set Uncle as default for BlockTransactionsrpc-types): set Uncle as default for BlockTransactions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
When fetching uncle blocks, these blocks never contain a
transactionsfield. This means that normal serialization into aBlockcan fail asBlockTransactionsdoesn't have a default and therefore will just not be added to theBlockstruct at all, causing a serde failure.Solution
In the case the field is missing, simply include the field as default with an
BlockTransactions::Uncleinstance.PR Checklist