chore: use workspace.lints (#676)

* chore: use workspace.lints

* docs

* chore: clippy

* doc

Cargo.toml

@@ -16,6 +16,27 @@ exclude = ["tests"]
 all-features = true
 rustdoc-args = ["--cfg", "docsrs"]
 
+[workspace.lints.clippy]
+dbg-macro = "warn"
+manual-string-new = "warn"
+uninlined-format-args = "warn"
+use-self = "warn"
+redundant-clone = "warn"
+missing-const-for-fn = "warn"
+
+[workspace.lints.rust]
+missing-copy-implementations = "warn"
+missing-debug-implementations = "warn"
+missing-docs = "warn"
+rust-2018-idioms = "warn"
+unreachable-pub = "warn"
+unused-must-use = "warn"
+redundant-lifetimes = "warn"
+unnameable-types = "warn"
+
+[workspace.lints.rustdoc]
+all = "warn"
+
 [workspace.dependencies]
 # workspace crates
 alloy-core = { version = "0.7.6", path = "crates/core", default-features = false }

crates/core/Cargo.toml

@@ -17,6 +17,9 @@ exclude.workspace = true
 all-features = true
 rustdoc-args = ["--cfg", "docsrs"]
 
+[lints]
+workspace = true
+
 [dependencies]
 alloy-primitives = { workspace = true, default-features = false }
 
@@ -27,7 +30,12 @@ alloy-sol-types = { workspace = true, default-features = false, optional = true
 alloy-rlp = { workspace = true, default-features = false, optional = true }
 
 [features]
-std = ["alloy-primitives/std", "alloy-json-abi?/std", "alloy-dyn-abi?/std", "alloy-sol-types?/std"]
+std = [
+    "alloy-primitives/std",
+    "alloy-json-abi?/std",
+    "alloy-dyn-abi?/std",
+    "alloy-sol-types?/std",
+]
 
 dyn-abi = ["sol-types", "dep:alloy-dyn-abi"]
 json-abi = ["json", "serde", "dep:alloy-json-abi"]

crates/core/src/lib.rs

@@ -3,18 +3,8 @@
     html_logo_url = "https://raw.githubusercontent.com/alloy-rs/core/main/assets/alloy.jpg",
     html_favicon_url = "https://raw.githubusercontent.com/alloy-rs/core/main/assets/favicon.ico"
 )]
-#![warn(
-    missing_copy_implementations,
-    missing_debug_implementations,
-    missing_docs,
-    unreachable_pub,
-    clippy::missing_const_for_fn,
-    rustdoc::all
-)]
 #![cfg_attr(not(test), warn(unused_crate_dependencies))]
-#![deny(unused_must_use, rust_2018_idioms)]
 #![cfg_attr(not(feature = "std"), no_std)]
-#![cfg_attr(feature = "std", allow(unused_imports))]
 #![cfg_attr(docsrs, feature(doc_cfg, doc_auto_cfg))]
 
 #[doc(inline)]

crates/dyn-abi/Cargo.toml

@@ -17,6 +17,9 @@ exclude.workspace = true
 all-features = true
 rustdoc-args = ["--cfg", "docsrs"]
 
+[lints]
+workspace = true
+
 [dependencies]
 alloy-json-abi.workspace = true
 alloy-sol-type-parser.workspace = true
@@ -55,7 +58,12 @@ std = [
     "serde?/std",
     "serde_json?/std",
 ]
-eip712 = ["alloy-sol-types/eip712-serde", "dep:derive_more", "dep:serde", "dep:serde_json"]
+eip712 = [
+    "alloy-sol-types/eip712-serde",
+    "dep:derive_more",
+    "dep:serde",
+    "dep:serde_json",
+]
 arbitrary = [
     "std",
     "alloy-sol-types/arbitrary",

crates/dyn-abi/benches/abi.rs

@@ -1,4 +1,4 @@
-#![allow(unknown_lints, clippy::incompatible_msrv)]
+#![allow(unknown_lints, clippy::incompatible_msrv, missing_docs)]
 
 use alloy_dyn_abi::{DynSolType, DynSolValue};
 use alloy_primitives::{hex, U256};

crates/dyn-abi/benches/types.rs

@@ -1,4 +1,4 @@
-#![allow(unknown_lints, clippy::incompatible_msrv)]
+#![allow(unknown_lints, clippy::incompatible_msrv, missing_docs)]
 
 use alloy_dyn_abi::{DynSolType, Specifier};
 use alloy_sol_type_parser::TypeSpecifier;

crates/dyn-abi/src/dynamic/call.rs

@@ -82,7 +82,7 @@ impl From<Vec<DynSolType>> for DynSolReturns {
 }
 
 impl From<DynSolReturns> for Vec<DynSolType> {
-    fn from(returns: DynSolReturns) -> Vec<DynSolType> {
+    fn from(returns: DynSolReturns) -> Self {
         returns.0
     }
 }

crates/dyn-abi/src/dynamic/token.rs

@@ -93,7 +93,7 @@ impl<'a> DynToken<'a> {
 
     /// Fallible cast into a fixed sequence.
     #[inline]
-    pub fn as_fixed_seq(&self) -> Option<(&[DynToken<'a>], usize)> {
+    pub fn as_fixed_seq(&self) -> Option<(&[Self], usize)> {
         match self {
             Self::FixedSeq(tokens, size) => Some((tokens, *size)),
             _ => None,
@@ -102,7 +102,7 @@ impl<'a> DynToken<'a> {
 
     /// Fallible cast into a dynamic sequence.
     #[inline]
-    pub fn as_dynamic_seq(&self) -> Option<&[DynToken<'a>]> {
+    pub fn as_dynamic_seq(&self) -> Option<&[Self]> {
         match self {
             Self::DynSeq { contents, .. } => Some(contents),
             _ => None,
@@ -111,7 +111,7 @@ impl<'a> DynToken<'a> {
 
     /// Fallible cast into a sequence, dynamic or fixed-size
     #[inline]
-    pub fn as_token_seq(&self) -> Option<&[DynToken<'a>]> {
+    pub fn as_token_seq(&self) -> Option<&[Self]> {
         match self {
             Self::FixedSeq(contents, _) | Self::DynSeq { contents, .. } => Some(contents),
             _ => None,

crates/dyn-abi/src/dynamic/ty.rs

@@ -158,17 +158,15 @@ impl DynSolType {
     /// depth of 0, while all other types have a nesting depth of at least 1.
     pub fn nesting_depth(&self) -> usize {
         match self {
-            DynSolType::Bool
-            | DynSolType::Int(_)
-            | DynSolType::Uint(_)
-            | DynSolType::FixedBytes(_)
-            | DynSolType::Address
-            | DynSolType::Function
-            | DynSolType::Bytes
-            | DynSolType::String => 0,
-            DynSolType::Array(contents) | DynSolType::FixedArray(contents, _) => {
-                1 + contents.nesting_depth()
-            }
+            Self::Bool
+            | Self::Int(_)
+            | Self::Uint(_)
+            | Self::FixedBytes(_)
+            | Self::Address
+            | Self::Function
+            | Self::Bytes
+            | Self::String => 0,
+            Self::Array(contents) | Self::FixedArray(contents, _) => 1 + contents.nesting_depth(),
             as_tuple!(Self tuple) => 1 + tuple.iter().map(Self::nesting_depth).max().unwrap_or(0),
         }
     }
@@ -565,21 +563,21 @@ impl DynSolType {
     pub fn minimum_words(&self) -> usize {
         match self {
             // word types are always 1
-            DynSolType::Bool |
-            DynSolType::Int(_) |
-            DynSolType::Uint(_) |
-            DynSolType::FixedBytes(_) |
-            DynSolType::Address |
-            DynSolType::Function |
+            Self::Bool |
+            Self::Int(_) |
+            Self::Uint(_) |
+            Self::FixedBytes(_) |
+            Self::Address |
+            Self::Function |
             // packed/dynamic seq types may be empty
-            DynSolType::Bytes |
-            DynSolType::String |
-            DynSolType::Array(_) => 1,
+            Self::Bytes |
+            Self::String |
+            Self::Array(_) => 1,
             // fixed-seq types are the sum of their components
-            DynSolType::FixedArray(v, size) => size * v.minimum_words(),
-            DynSolType::Tuple(tuple) => tuple.iter().map(|ty| ty.minimum_words()).sum(),
+            Self::FixedArray(v, size) => size * v.minimum_words(),
+            Self::Tuple(tuple) => tuple.iter().map(|ty| ty.minimum_words()).sum(),
             #[cfg(feature = "eip712")]
-            DynSolType::CustomStruct { tuple, ..} => tuple.iter().map(|ty| ty.minimum_words()).sum(),
+            Self::CustomStruct { tuple, ..} => tuple.iter().map(|ty| ty.minimum_words()).sum(),
         }
     }
 

crates/dyn-abi/src/ext/abi.rs

@@ -4,6 +4,7 @@ use alloy_json_abi::{Constructor, Error, Function, Param};
 use alloy_primitives::Selector;
 use alloy_sol_types::abi::Decoder;
 
+#[allow(unknown_lints, unnameable_types)]
 mod sealed {
     pub trait Sealed {}
     impl Sealed for super::Constructor {}

crates/dyn-abi/src/ext/error.rs

@@ -3,6 +3,7 @@ use alloc::vec::Vec;
 use alloy_json_abi::Error;
 use alloy_primitives::{keccak256, Selector};
 
+#[allow(unknown_lints, unnameable_types)]
 mod sealed {
     pub trait Sealed {}
     impl Sealed for alloy_json_abi::Error {}

crates/dyn-abi/src/ext/event.rs

@@ -3,6 +3,7 @@ use alloc::vec::Vec;
 use alloy_json_abi::Event;
 use alloy_primitives::{LogData, B256};
 
+#[allow(unknown_lints, unnameable_types)]
 mod sealed {
     pub trait Sealed {}
     impl Sealed for alloy_json_abi::Event {}

crates/dyn-abi/src/lib.rs

@@ -12,18 +12,8 @@
     html_logo_url = "https://raw.githubusercontent.com/alloy-rs/core/main/assets/alloy.jpg",
     html_favicon_url = "https://raw.githubusercontent.com/alloy-rs/core/main/assets/favicon.ico"
 )]
-#![warn(
-    missing_copy_implementations,
-    missing_debug_implementations,
-    missing_docs,
-    unreachable_pub,
-    clippy::missing_const_for_fn,
-    rustdoc::all
-)]
 #![cfg_attr(not(test), warn(unused_crate_dependencies))]
-#![deny(unused_must_use, rust_2018_idioms)]
 #![cfg_attr(not(feature = "std"), no_std)]
-#![cfg_attr(feature = "std", allow(unused_imports))]
 #![cfg_attr(docsrs, feature(doc_cfg, doc_auto_cfg))]
 
 #[macro_use]

crates/json-abi/src/lib.rs

@@ -12,18 +12,8 @@
     html_logo_url = "https://raw.githubusercontent.com/alloy-rs/core/main/assets/alloy.jpg",
     html_favicon_url = "https://raw.githubusercontent.com/alloy-rs/core/main/assets/favicon.ico"
 )]
-#![warn(
-    missing_copy_implementations,
-    missing_debug_implementations,
-    missing_docs,
-    unreachable_pub,
-    clippy::missing_const_for_fn,
-    rustdoc::all
-)]
 #![cfg_attr(not(test), warn(unused_crate_dependencies))]
-#![deny(unused_must_use, rust_2018_idioms)]
 #![cfg_attr(not(feature = "std"), no_std)]
-#![cfg_attr(feature = "std", allow(unused_imports))]
 #![cfg_attr(docsrs, feature(doc_cfg, doc_auto_cfg))]
 
 #[macro_use]

crates/primitives/Cargo.toml

@@ -17,6 +17,9 @@ exclude.workspace = true
 all-features = true
 rustdoc-args = ["--cfg", "docsrs"]
 
+[lints]
+workspace = true
+
 [dependencies]
 bytes.workspace = true
 hex-literal.workspace = true

crates/primitives/benches/primitives.rs

@@ -1,4 +1,4 @@
-#![allow(unknown_lints, clippy::incompatible_msrv)]
+#![allow(unknown_lints, clippy::incompatible_msrv, missing_docs)]
 
 use alloy_primitives::{keccak256, Address, B256};
 use criterion::{criterion_group, criterion_main, Criterion};

crates/primitives/src/common.rs

@@ -21,8 +21,8 @@ impl From<Option<Address>> for TxKind {
     #[inline]
     fn from(value: Option<Address>) -> Self {
         match value {
-            None => TxKind::Create,
-            Some(addr) => TxKind::Call(addr),
+            None => Self::Create,
+            Some(addr) => Self::Call(addr),
         }
     }
 }
@@ -31,29 +31,29 @@ impl From<Address> for TxKind {
     /// Creates a `TxKind::Call` with the given address.
     #[inline]
     fn from(value: Address) -> Self {
-        TxKind::Call(value)
+        Self::Call(value)
     }
 }
 
 impl TxKind {
     /// Returns the address of the contract that will be called or will receive the transfer.
     pub const fn to(&self) -> Option<&Address> {
         match self {
-            TxKind::Create => None,
-            TxKind::Call(to) => Some(to),
+            Self::Create => None,
+            Self::Call(to) => Some(to),
         }
     }
 
     /// Returns true if the transaction is a contract creation.
     #[inline]
     pub const fn is_create(&self) -> bool {
-        matches!(self, TxKind::Create)
+        matches!(self, Self::Create)
     }
 
     /// Returns true if the transaction is a contract call.
     #[inline]
     pub const fn is_call(&self) -> bool {
-        matches!(self, TxKind::Call(_))
+        matches!(self, Self::Call(_))
     }
 
     /// Calculates a heuristic for the in-memory size of this object.
@@ -67,15 +67,15 @@ impl TxKind {
 impl Encodable for TxKind {
     fn encode(&self, out: &mut dyn BufMut) {
         match self {
-            TxKind::Call(to) => to.encode(out),
-            TxKind::Create => out.put_u8(EMPTY_STRING_CODE),
+            Self::Call(to) => to.encode(out),
+            Self::Create => out.put_u8(EMPTY_STRING_CODE),
         }
     }
 
     fn length(&self) -> usize {
         match self {
-            TxKind::Call(to) => to.length(),
-            TxKind::Create => 1, // EMPTY_STRING_CODE is a single byte
+            Self::Call(to) => to.length(),
+            Self::Create => 1, // EMPTY_STRING_CODE is a single byte
         }
     }
 }
@@ -86,10 +86,10 @@ impl Decodable for TxKind {
         if let Some(&first) = buf.first() {
             if first == EMPTY_STRING_CODE {
                 buf.advance(1);
-                Ok(TxKind::Create)
+                Ok(Self::Create)
             } else {
                 let addr = <Address as Decodable>::decode(buf)?;
-                Ok(TxKind::Call(addr))
+                Ok(Self::Call(addr))
             }
         } else {
             Err(alloy_rlp::Error::InputTooShort)

crates/primitives/src/lib.rs

@@ -3,18 +3,8 @@
     html_logo_url = "https://raw.githubusercontent.com/alloy-rs/core/main/assets/alloy.jpg",
     html_favicon_url = "https://raw.githubusercontent.com/alloy-rs/core/main/assets/favicon.ico"
 )]
-#![warn(
-    missing_copy_implementations,
-    missing_debug_implementations,
-    missing_docs,
-    unreachable_pub,
-    clippy::missing_const_for_fn,
-    rustdoc::all
-)]
 #![cfg_attr(not(test), warn(unused_crate_dependencies))]
-#![deny(unused_must_use, rust_2018_idioms)]
 #![cfg_attr(not(feature = "std"), no_std)]
-#![cfg_attr(feature = "std", allow(unused_imports))]
 #![cfg_attr(docsrs, feature(doc_cfg, doc_auto_cfg))]
 // TODO: remove when https://github.com/proptest-rs/proptest/pull/427 is merged
 #![allow(unknown_lints, non_local_definitions)]

crates/primitives/src/log_serde.rs

@@ -49,7 +49,7 @@ impl<T: Serialize> Serialize for Log<T> {
     where
         S: Serializer,
     {
-        let Log { address, data } = self;
+        let Self { address, data } = self;
         if serializer.is_human_readable() {
             let replace = LogFlattenSerializer { address, data };
             replace.serialize(serializer)

crates/primitives/src/signature/sig.rs

@@ -1,3 +1,5 @@
+#![allow(unknown_lints, unnameable_types)]
+
 use crate::{
     hex,
     signature::{Parity, SignatureError},