Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Expected Parenthesizes #349

Closed
Will-Smith11 opened this issue Oct 8, 2023 · 4 comments · Fixed by #354
Closed

[Bug] Expected Parenthesizes #349

Will-Smith11 opened this issue Oct 8, 2023 · 4 comments · Fixed by #354
Labels
bug Something isn't working

Comments

@Will-Smith11
Copy link
Contributor

Component

sol! macro

What version of Alloy are you on?

No response

Operating System

None

Describe the bug

image
https://etherscan.io/address/0x080bf510fcbf18b91105470639e9561022937712#code

@Will-Smith11 Will-Smith11 added the bug Something isn't working label Oct 8, 2023
@Will-Smith11
Copy link
Contributor Author

something similar but differnet wording of error message
image

@DaniPopes
Copy link
Member

Looks like Solc 0.4.X ABI does not have internalType: we fallback to emitting tuple or tuple[] -> the parser expects a tuple(...) type -> no parens found

@DaniPopes
Copy link
Member

I don't think we can do anything about this, since name information is lost, unless we make up names for each custom struct we encounter and emit it separately. At that point I'd rather just not support this since it blows up in complexity

@DaniPopes
Copy link
Member

We could emit tuple types inline like function f(address a, (uint, bool) b). This is not valid Solidity since there are no tuple types, but we do support it in sol!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants