fix(json-abi): fallback to tuple types for nested params in to_sol
#354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DaniPopes
changed the title
to_solto_sol
DaniPopes
force-pushed
the
dani/json-tuple-types
branch
from
362ea4b
to
7a55e0a
Compare
This was referenced Oct 9, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fixes #349
Solution
When the param type is
tupleortuple[N?]..., emit a tuple type(T, U, V, ...)instead of just the word "tuple" which trips upsyn-solidity.This can only happen in Solc 0.4.X ABI.
This is not actually valid Solidity, but it works in
sol!and with other more lenient parser like inforge fmt.PR Checklist