New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Why redefine this mask function when ruint crate already have same mask function? #695

Closed

rongyi opened this issue Jul 26, 2024 · 1 comment · Fixed by #698

Contributor

rongyi commented Jul 26, 2024 •

edited

Loading

core/crates/primitives/src/signed/int.rs

Line 107 in adcf7ad

pub(crate) const MASK: u64 = mask(BITS);

https://github.com/recmo/uint/blob/c4616bdb1bcdaa991ef23f9808c56c86127625ea/src/lib.rs#L321

Member

mattsse commented Jul 26, 2024

this is indeed duplicated and could be reused since it appears to be public ruint api

DaniPopes mentioned this issue

chore(primitives): re-use ruint mask function #698

Merged

3 tasks

DaniPopes closed this as completed in #698

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment