Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(primitives): re-use ruint mask function #698

Merged
merged 1 commit into from
Jul 28, 2024

Conversation

rongyi
Copy link
Contributor

@rongyi rongyi commented Jul 28, 2024

the underline ruint crate already have mask method

Motivation

DRY

Solution

use ruint::mask

Fix #695

PR Checklist

  • Added Tests
  • Added Documentation
  • Breaking changes

@rongyi rongyi requested a review from DaniPopes as a code owner July 28, 2024 03:45
Copy link
Member

@DaniPopes DaniPopes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@DaniPopes DaniPopes changed the title Fix #695 chore(primitives): re-use ruint mask function Jul 28, 2024
@DaniPopes DaniPopes merged commit 6540523 into alloy-rs:main Jul 28, 2024
30 checks passed
klkvr pushed a commit that referenced this pull request Aug 4, 2024
Drop duplicate mask method, underline crate ruint already have this method.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Why redefine this mask function when ruint crate already have same mask function?
2 participants