Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename Sol*::Tuple to Parameters/Arguments #91

Closed
DaniPopes opened this issue Jun 9, 2023 · 2 comments · Fixed by #145
Closed

Rename Sol*::Tuple to Parameters/Arguments #91

DaniPopes opened this issue Jun 9, 2023 · 2 comments · Fixed by #145
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@DaniPopes
Copy link
Member

DaniPopes commented Jun 9, 2023 •
edited
Loading

Rename SolError::Tuple to SolError::Parameters, SolCall::Tuple to SolCall::Arguments
@DaniPopes DaniPopes added enhancement New feature or request good first issue Good for newcomers labels Jun 9, 2023
@shawnharmsen
Copy link
Contributor

would like to take a stab at this please, will open pr soon

@prestwich
Copy link
Member

only gotcha is that it needs to be changed in the proc macro codegen in sol-macro/src/expand/ as well as in the traits in sol-type/src/types

@shawnharmsen shawnharmsen mentioned this issue Jun 24, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: Rename Sol*::Tuple to Parameters/Arguments shawnharmsen/core
3 participants
@shawnharmsen @prestwich @DaniPopes