refactor: Rename Sol*::Tuple to Parameters/Arguments #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shawnharmsen
requested review from
DaniPopes,
prestwich and
gakonst
as code owners
|
i introduced some conflicts so i'll take care of those rq and then get this in |
prestwich
force-pushed
the
rename-sol-tuple
branch
from
ad84cc4
to
439af07
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #91
Motivation
"When you come to a fork in the road, take it." - Yogi Berra
Solution
checked with
cargo check --all-features cargo +nightly fmt --all cargo build --all-features cargo test --all-features cargo +nightly clippy --all-featuresPR Checklist
simple name change