Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: sol-macro expansion #113

Merged
merged 2 commits into from
Jun 16, 2023
Merged

refactor: sol-macro expansion #113

merged 2 commits into from
Jun 16, 2023
+836 −697

Conversation

DaniPopes
Copy link
Member

Motivation

Closes #98

Solution

PR Checklist

  • Added Tests
  • Added Documentation
  • Breaking changes

@DaniPopes DaniPopes force-pushed the dani/refactor-sol2 branch 2 times, most recently from 4eb709d to 80c4eff Compare June 14, 2023 17:36
@DaniPopes DaniPopes force-pushed the dani/refactor-sol2 branch from 80c4eff to 6df5798 Compare June 14, 2023 18:32
prestwich
prestwich approved these changes Jun 16, 2023
View reviewed changes
Copy link
Member

@prestwich prestwich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

big improvement in maintainability <3

@DaniPopes DaniPopes merged commit a4186a5 into main Jun 16, 2023
@DaniPopes DaniPopes deleted the dani/refactor-sol2 branch June 16, 2023 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prestwich prestwich prestwich approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor sol_macro::expand
2 participants
@DaniPopes @prestwich