refactor: do not generate SolCall for return values #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DaniPopes
requested changes
Jun 21, 2023
prestwich
force-pushed
the
prestwich/sol-call-cleanup
branch
from
ea1b636
to
cf79abc
Compare
Co-authored-by: DaniPopes <57450786+DaniPopes@users.noreply.github.com>
Co-authored-by: DaniPopes <57450786+DaniPopes@users.noreply.github.com>
prestwich
force-pushed
the
prestwich/sol-call-cleanup
branch
from
cf79abc
to
0eda8d4
Compare
DaniPopes
reviewed
Jun 23, 2023
Comment on lines
22
to
28
| /// pub struct #{name}Return { | ||
| /// #(pub #return_name: #return_type,)* | ||
| /// } | ||
| /// | ||
| /// impl SolCall for #{name}Return { | ||
| /// impl SolFunction for #{name}Return { | ||
| /// ... | ||
| /// } |
DaniPopes
requested changes
Jun 24, 2023
Comment on lines
+33
to
+34
| /// For example the following input: | ||
| /// `function foo(uint256 a, uint256 b) external view returns (uint256);` |
There was a problem hiding this comment.
this is the doc comment's function
There was a problem hiding this comment.
yeah the rest of it was generic about macro functionality so i decided to be as explicit as possible
Comment on lines
+123
to
+124
| { #converts } | ||
| { #return_converts } |
There was a problem hiding this comment.
both generate a type alias named UnderlyingSolTuple. the scope prevents a name conflict
Co-authored-by: DaniPopes <57450786+DaniPopes@users.noreply.github.com>
DaniPopes
approved these changes
Jun 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #95
Motivation
Generating
SolCalfor return values led to bad outcomes like traits with incorrect signatures.Solution
Instead this PR simply treats the return type as a tuple (as solidity does), and adds
decode_returnsandencode_returnsfunctions to theSolCalltraitPR Checklist