Refactoring dyn-abi to performance parity with ethabi
#144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prestwich
changed the title
dyn-abidyn-abi to performance parity with ethabi
prestwich
commented
Jun 25, 2023
| let input = encode_struct_sol_values(); | ||
| let input = DynSolValue::Tuple(input.to_vec()); | ||
| b.iter(|| ty.encode_single(black_box(&input).clone())); |
There was a problem hiding this comment.
this was doing an extra alloc in the encode_single
DaniPopes
approved these changes
Jun 26, 2023
|
Can you share the benchmark results (with % gains)? |
|
Here's the comparison to main. To generate this I ran A significant % of gains were from making the benches apples-to-apples. The versions in main actually cause the dyn-abi to do extra work that ethabi was not required to. I'd guess that about 100ns of the improvement is from making the bench equivalent
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR brings dyn-abi to performance parity with ethabi (or better) on all benchmarks
It does this by
Followup work may bypass decoding into tokens and decode directly into values
Motivation
dyn-abi is slow and should be fast 😤
Solution
make it faster
PR Checklist