Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename domain macro and add more docs #147

Merged
merged 1 commit into from
Jun 25, 2023
Merged

Rename domain macro and add more docs #147

merged 1 commit into from
Jun 25, 2023

Conversation

prestwich
Copy link
Member

Motivation

domain is not a specific enough name.

Solution

Call it eip712_domain

PR Checklist

  • Added Tests
  • Added Documentation
  • Breaking changes

@prestwich prestwich added the enhancement New feature or request label Jun 25, 2023
@prestwich prestwich self-assigned this Jun 25, 2023
@prestwich prestwich merged commit 7b8c1d7 into main Jun 25, 2023
@DaniPopes DaniPopes deleted the prestwich/domain-macro-rename branch June 27, 2023 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DaniPopes DaniPopes DaniPopes approved these changes

Assignees

@prestwich prestwich

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@prestwich @DaniPopes