Format and comment fixes #149
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DaniPopes
reviewed
Jun 25, 2023
crates/primitives/src/bits/macros.rs
Outdated
| @@ -173,7 +173,7 @@ macro_rules! wrap_fixed_bytes { | |||
| /// Returns the inner bytes array. | |||
| #[inline] | |||
| pub const fn into_array(self) -> [u8; $n] { | |||
| self.0 .0 | |||
| self.0.0 | |||
There was a problem hiding this comment.
This is actually intentional since Rust parses the 0.0 as a float literal and rustfmt will prefer the separated version, but both work
There was a problem hiding this comment.
Oh ok, had no idea. Thanks for explaining!
Just out of curiosity where did you learn about a thing like that? Did you work on the formatter or something?😂
There was a problem hiding this comment.
rustfmt formats self.0.0 to self.0 .0 if you try it (top left, tools -> rustfmt):
https://play.rust-lang.org/?version=stable&mode=debug&edition=2021&gist=fc90885df6ae8d4805352d11061f9a2b
DaniPopes
approved these changes
Jun 25, 2023
|
this work is now in #151 because the rebase did something weird to github's interpretation of the branch and i can't reopen this. 😮💨 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Very minor pr that fixes a weird format error and 2 comments.