Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prestwich/ingest encode type #15

Merged
merged 7 commits into from
Apr 25, 2023
Merged

Prestwich/ingest encode type #15

merged 7 commits into from
Apr 25, 2023

Conversation

prestwich
Copy link
Member

@prestwich prestwich commented Apr 25, 2023

  • resolver ingest an encodeType string
  • resolver ingest a solStruct
  • fix bug in sol! struct definition that broke 1-element tuples
  • TypedData from sol struct

Fixes #10

@prestwich prestwich added bug Something isn't working enhancement New feature or request labels Apr 25, 2023
@prestwich prestwich self-assigned this Apr 25, 2023
@prestwich
Copy link
Member Author

ready for review 🖖

abi/sol-type-parser/src/lib.rs Outdated Show resolved Hide resolved
dyn-abi/src/eip712/parser.rs Show resolved Hide resolved
dyn-abi/src/eip712/resolver.rs Outdated Show resolved Hide resolved
Copy link
Member

@DaniPopes DaniPopes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, added fixes comment for #10

@prestwich prestwich enabled auto-merge (squash) April 25, 2023 20:15
@prestwich prestwich merged commit 81fe979 into main Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix no_std tests by correcting imports
2 participants