Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: clean ups #150

Merged
merged 5 commits into from
Jun 25, 2023
Merged

chore: clean ups #150

merged 5 commits into from
Jun 25, 2023

Conversation

DaniPopes
Copy link
Member

Motivation

Solution

  • d6fb51d: random stuff i found
  • c43ac05: rename no_std_prelude to private and export some more items
  • 5228cf7: refactor eip712_domain to use only 1 arm with the question mark repetition $()?

PR Checklist

  • Added Tests
  • Added Documentation
  • Breaking changes

@DaniPopes DaniPopes requested a review from gakonst as a code owner June 25, 2023 18:34
DaniPopes
DaniPopes commented Jun 25, 2023
View reviewed changes
crates/sol-types/src/types/data_type.rs
Copy link
Member Author

@DaniPopes DaniPopes Jun 25, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The diff is pretty horrendous here, but the start is just swapping Address with Bool

prestwich
prestwich approved these changes Jun 25, 2023
View reviewed changes
Copy link
Member

@prestwich prestwich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG2M

@DaniPopes DaniPopes merged commit f3e46f6 into main Jun 25, 2023
@DaniPopes DaniPopes deleted the dani/chores branch June 27, 2023 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prestwich prestwich prestwich approved these changes

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DaniPopes @prestwich