Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(sol-types): empty data decode #159

Merged
merged 1 commit into from
Jun 27, 2023
Merged

fix(sol-types): empty data decode #159

merged 1 commit into from
Jun 27, 2023

Conversation

DaniPopes
Copy link
Member

@DaniPopes DaniPopes commented Jun 27, 2023 •
edited
Loading

Motivation

Fixes #158

Solution

Use the unit type for TokenType in its own SolType impl, and don't check for empty data when decoding

PR Checklist

  • Added Tests
  • Added Documentation
  • Breaking changes

@DaniPopes DaniPopes merged commit b755263 into main Jun 27, 2023
@DaniPopes DaniPopes deleted the dani/fix-empty-decode branch June 27, 2023 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prestwich prestwich prestwich approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] Cant decode Solidity calls to functions with no arguments
2 participants
@DaniPopes @prestwich