Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove unwrap in decode_populate #172

Merged
merged 1 commit into from
Jul 3, 2023
Merged

fix: remove unwrap in decode_populate #172

merged 1 commit into from
Jul 3, 2023

Conversation

prestwich
Copy link
Member

@prestwich prestwich commented Jul 3, 2023 •
edited by DaniPopes
Loading

Motivation

Fixes #170

Solution

Remove a reachable and unnecessary unwrap in decode_populate.

PR Checklist

  • Added Tests
  • Added Documentation
  • Breaking changes

@prestwich prestwich added the bug Something isn't working label Jul 3, 2023
@prestwich prestwich self-assigned this Jul 3, 2023
@prestwich prestwich requested a review from DaniPopes July 3, 2023 21:36
@DaniPopes DaniPopes merged commit 96b150d into main Jul 3, 2023
@DaniPopes DaniPopes deleted the prestwich/dyn-abi-panic branch July 3, 2023 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DaniPopes DaniPopes DaniPopes approved these changes

Assignees

@prestwich prestwich

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] Dynamic data may cause decode_single to panic
2 participants
@prestwich @DaniPopes