Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(dyn-abi): clean up and improve performance #174

Merged
merged 2 commits into from
Jul 4, 2023
Merged

feat(dyn-abi): clean up and improve performance #174

merged 2 commits into from
Jul 4, 2023

Conversation

DaniPopes
Copy link
Member

@DaniPopes DaniPopes commented Jul 4, 2023 •
edited
Loading

Motivation

  • bunch of moving around
  • perf improvements in dyn-abi types and encoder
  • Encoder::with_capacity: allocate for 8 suffix_offsets
  • improve DynSol*::sol_type_name to avoid allocating
  • improve string sol type parser (alloy_dyn_abi::parser)

Solution

PR Checklist

  • Added Tests
  • Added Documentation
  • Breaking changes

@DaniPopes DaniPopes added the enhancement New feature or request label Jul 4, 2023
prestwich
prestwich requested changes Jul 4, 2023
View reviewed changes
Copy link
Member

@prestwich prestwich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good. needs clippy and fmt

@DaniPopes DaniPopes mentioned this pull request Jul 4, 2023
Merged
3 tasks
@DaniPopes DaniPopes enabled auto-merge (squash) July 4, 2023 19:40
prestwich
prestwich approved these changes Jul 4, 2023
View reviewed changes
Copy link
Member

@prestwich prestwich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool

@DaniPopes DaniPopes merged commit 9c85a28 into main Jul 4, 2023
@DaniPopes DaniPopes deleted the dani/dyn-improvements branch July 4, 2023 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prestwich prestwich prestwich approved these changes

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DaniPopes @prestwich