chore(dyn-abi): gate eip712 behind a feature #176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DaniPopes
force-pushed
the
dani/dyn-proptests
branch
from
865bed6
to
674ed23
Compare
DaniPopes
force-pushed
the
dani/dyn-eip712-feature
branch
from
78f0045
to
1d886b3
Compare
DaniPopes
force-pushed
the
dani/dyn-eip712-feature
branch
from
1d886b3
to
3b12051
Compare
prestwich
reviewed
Jul 4, 2023
| DynAbiError::MissingType(name) => write!(f, "Missing type in type resolution: {name}"), | ||
| DynAbiError::CircularDependency(dep) => write!(f, "Circular dependency: {dep}"), | ||
| DynAbiError::InvalidPropertyDefinition(def) => { | ||
| write!(f, "Invalid property definition: {def}") | ||
| } | ||
|
|
prestwich
approved these changes
Jul 4, 2023
DaniPopes
force-pushed
the
dani/dyn-eip712-feature
branch
from
325a915
to
8bad62d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Solution
PR Checklist