Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: move rlp crates to a separate repo #187

Merged
merged 1 commit into from
Jul 12, 2023
Merged

chore: move rlp crates to a separate repo #187

merged 1 commit into from
Jul 12, 2023

Conversation

DaniPopes
Copy link
Member

@DaniPopes DaniPopes commented Jul 12, 2023 •
edited
Loading

Motivation

https://github.com/alloy-rs/rlp

Allows maintaining separate versioning for alloy-rlp[-derive] so that ruint can depend on it

Solution

PR Checklist

  • Added Tests
  • Added Documentation
  • Breaking changes

gakonst
gakonst approved these changes Jul 12, 2023
View reviewed changes
Copy link
Member

@gakonst gakonst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Supportive as discussed

@gakonst gakonst merged commit 07f087c into main Jul 12, 2023
@DaniPopes DaniPopes deleted the dani/move-rlp branch July 12, 2023 10:35
@DaniPopes DaniPopes mentioned this pull request Jul 13, 2023
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gakonst gakonst gakonst approved these changes

@prestwich prestwich Awaiting requested review from prestwich

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DaniPopes @gakonst