-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support ethabi
Contract methods
#195
Conversation
ethabi
Contract methods
When writing tests for
I used the same implementation as
Do you know how to solve this? Tried adding
|
nevermind i am dumb it's in the folder already |
okay i have tracked this down.
|
@andyrobert3 if you don't mind, I can push a fix to your branch. the fix will be loading the entire file into a string and then chaning to |
sure @prestwich feel free to push! need to sleep since its a bit late here |
cool i pushed. this solves the immediate issue, and should make it clearer for future users :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rest LGTM
needs |
@DaniPopes mind re-reviewing with my additions? :) |
Was going to work on the requested changes today, but thanks to @prestwich @DaniPopes for reviewing and making the required changes |
yeah, hope you don't mind us getting it over the finish line. thank you for your contribution! 🎉 |
Motivation
Fixes #101
Struggling to write tests forload
method fromethabi
Thanks @prestwich for the help!
Solution
Reference from methods from
ethabi
PR Checklist