Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(syn-solidity): add statements and expressions #199

Merged
merged 27 commits into from
Aug 23, 2023

Conversation

Will-Smith11
Copy link
Contributor

Cooking for another project and thought why not make a pr request. I gotta do testing and im pretty sure ive missed a few cases. However just going to keep cooking at ethcc and will do cleanup later

@prestwich
Copy link
Member

when writing rustdoc for the structs, can you reference the corresponding structure in the solidity grammar for each type?

@Will-Smith11
Copy link
Contributor Author

when writing rustdoc for the structs, can you reference the corresponding structure in the solidity grammar for each type?

oooo like this yes

Copy link
Member

@gakonst gakonst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice - the idea here is to comptime transpile solidity to rust directly w/o jit'ing into any lower level code rigth?

@Will-Smith11
Copy link
Contributor Author

nice - the idea here is to comptime transpile solidity to rust directly w/o jit'ing into any lower level code rigth?

yeah exactly. also a lot more user friendly to work with. I need to write some tests and stuff but super busy with work rn so the progress will be slow for the next little bit. Ik some of the Primitive devs where also interested in doing a paper based off the results not only looking at speed differences but llvm compile difference when comparing to revm.

@DaniPopes
Copy link
Member

Hey @Will-Smith11, I have some free time these coming days, do you mind if I pick this up?

@Will-Smith11
Copy link
Contributor Author

Hey @Will-Smith11, I have some free time these coming days, do you mind if I pick this up?

go for it!

@DaniPopes DaniPopes marked this pull request as ready for review August 5, 2023 16:40
@DaniPopes DaniPopes self-requested a review as a code owner August 5, 2023 16:40
@DaniPopes DaniPopes changed the title feat: add stmt parsing feat(syn-solidity): add statements and expressions Aug 5, 2023
@Will-Smith11
Copy link
Contributor Author

@DaniPopes What is left to be done? I have some free time this weekend and want to push this forward?

@DaniPopes
Copy link
Member

Not much, the only thing is testing that the parsed output is what we expected, instead of just "it parses". Also operation order might not be entirely correct

@Will-Smith11
Copy link
Contributor Author

Not much, the only thing is testing that the parsed output is what we expected, instead of just "it parses". Also operation order might not be entirely correct

👍

@gakonst
Copy link
Member

gakonst commented Aug 18, 2023

@Will-Smith11 would love if you PoC'ed a benchmark comparing Revm+Solidity compiled vs native transpiled with syn-solidity, Im curious how you see this working for e.g. projects like uniswap-v3

@DaniPopes
Copy link
Member

Merging for now, will open a few issues with what's missing.

@DaniPopes DaniPopes merged commit 4298501 into alloy-rs:main Aug 23, 2023
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants