Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove unused method body on solstruct #200

Merged
merged 3 commits into from
Jul 20, 2023
Merged

fix: remove unused method body on solstruct #200

merged 3 commits into from
Jul 20, 2023

Conversation

prestwich
Copy link
Member

SolStruct::eip712_encode_type is incorrect and always overridden by sol macro.

We remove it

PR Checklist

  • Added Tests
  • Added Documentation
  • Breaking changes

@prestwich prestwich added the bug Something isn't working label Jul 20, 2023
@prestwich prestwich self-assigned this Jul 20, 2023
@prestwich prestwich marked this pull request as ready for review July 20, 2023 06:13
@DaniPopes
Copy link
Member

maybe we can also remove name and field constants after this?

@prestwich
Copy link
Member Author

I've removed fields 🙌

NAME is used in the blanket SolType impl. So removing it implies doing #36. Save that for another PR?

@prestwich prestwich merged commit 3d89ec5 into main Jul 20, 2023
@prestwich prestwich deleted the prestwich/delete-body branch July 26, 2023 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DaniPopes DaniPopes DaniPopes approved these changes

Assignees

@prestwich prestwich

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@prestwich @DaniPopes