fix: correct encodeType expansion for nested structs #203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DaniPopes
requested changes
Jul 21, 2023
| /// Returns component EIP-712 types. These types are used to construct | ||
| /// the `encodeType` string. These are the types of the struct's fields, | ||
| /// and should not include the root type. | ||
| fn eip712_components() -> Vec<Cow<'static, str>>; |
There was a problem hiding this comment.
should this even be exposed? are there any other use cases
There was a problem hiding this comment.
unless we go through some extra trait wrangling, we can't both
- use it in the default impl of
eip712_encode_type - not expose it
Is there a specific setup you'd prefer?
DaniPopes
approved these changes
Jul 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
#201
Solution
eip712_root_typeandeip712_component_typesto get typestrings on the flyeip712_encode_typeThis is a bit clunky. I don't love it
PR Checklist