Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: sol macro parsing and expansion #21

Merged
merged 8 commits into from
May 6, 2023
Merged

fix: sol macro parsing and expansion #21

merged 8 commits into from
May 6, 2023

Conversation

DaniPopes
Copy link
Member

@DaniPopes DaniPopes commented May 3, 2023 •
edited
Loading

Using syn's fork is discouraged because it makes debugging hard and errors ugly (I encountered this)

  • Parse any outer attributes, then parse based on the next token
  • Refactor SolType to use spans
  • Use Ident::parse_any to ignore Rust keywords when parsing types
  • Fix parsing types that start with bytes, int or uint

@DaniPopes DaniPopes requested a review from prestwich May 3, 2023 21:10
@prestwich
Copy link
Member

😍 😻

@DaniPopes DaniPopes enabled auto-merge (squash) May 4, 2023 18:17
@DaniPopes DaniPopes mentioned this pull request May 5, 2023
Merged
@DaniPopes DaniPopes merged commit 353a891 into main May 6, 2023
@DaniPopes DaniPopes deleted the dani/fix-macros branch May 15, 2023 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prestwich prestwich prestwich approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DaniPopes @prestwich