fix(sol-macro): encode UDVTs as their underlying type in EIP-712 #220
+116
−59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DaniPopes
force-pushed
the
dani/sol-udt-structs
branch
5 times, most recently
from
7d24bf6
to
a901d97
Compare
DaniPopes
force-pushed
the
dani/sol-udt-structs
branch
from
a901d97
to
bf129ca
Compare
prestwich
approved these changes
Aug 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fixes #219
Solution
Check for
UDVTs when computing struct eip712 root type and signature.Also implement
EventTopicforUDVTs declared with the macro, as it is also needed.PR Checklist