feat(dyn-abi): allow T: Into<Cow<str>> in eip712_domain!
#222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DaniPopes
commented
Aug 2, 2023
| /// According to the MetaMask implementation, | ||
| /// the message parameter may be JSON stringified in versions later than V1 | ||
| /// See <https://github.com/MetaMask/metamask-extension/blob/0dfdd44ae7728ed02cbf32c564c75b74f37acf77/app/scripts/metamask-controller.js#L1736> | ||
| /// In fact, ethers.js JSON stringifies the message at the time of writing. | ||
| /// `TypedData` is most likely going to be a stringified JSON object, so we have | ||
| /// to implement Deserialize manually to parse the string first. | ||
| /// | ||
| /// See: | ||
| /// - Ethers.js: <https://github.com/ethers-io/ethers.js/blob/17969fe4169b44389dbd4da1dd85682eb3284d6f/src.ts/providers/provider-jsonrpc.ts#L415> | ||
| /// - Viem: <https://github.com/wagmi-dev/viem/blob/9aba19289832b22422e57265258fdf4beba83570/src/actions/wallet/signTypedData.ts#L178-L185> |
There was a problem hiding this comment.
This link points to a 3 year old commit in Metamask which very hard to trace to today's implementations, so I updated this doc
DaniPopes
force-pushed
the
dani/runtime-eip712-domain
branch
2 times, most recently
from
0fa5215
to
67a4dc4
Compare
|
Clippy fixed in #218 |
DaniPopes
force-pushed
the
dani/runtime-eip712-domain
branch
from
67a4dc4
to
aeec7ed
Compare
DaniPopes
force-pushed
the
dani/runtime-eip712-domain
branch
from
aeec7ed
to
eb14a04
Compare
prestwich
approved these changes
Aug 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Minor improvement to the
eip712_domain!macro.Solution
If an
expris aliteral, then useCow::Borrowed, else useCow::from.PR Checklist