Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement abi2sol #228

Merged
merged 1 commit into from
Aug 23, 2023
Merged

feat: implement abi2sol #228

merged 1 commit into from
Aug 23, 2023

Conversation

DaniPopes
Copy link
Member

@DaniPopes DaniPopes commented Aug 13, 2023

Motivation

Rewrite code that generates Solidity tokens from a JsonAbi in sol-macro to use strings in json-abi.

Solution

PR Checklist

  • Added Tests
  • Added Documentation
  • [no] Breaking changes

Copy link
Member

@prestwich prestwich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it seems like we want to unify this to_sol with syn-solidity somehow, no? rather than assembling strings like this, we should consider converting abi json to syn-solidity types and then having a pipeline for converting syn-solidity into sol files?

@DaniPopes
Copy link
Member Author

I want this to produce a string which can be used in both. There is no need to implement it specifically for the ast

@prestwich
Copy link
Member

my point is that "converting type specifications to solidity strings" is probably a common action that we should capture in a single location. should we capture it here, or elsewhere?

@DaniPopes
Copy link
Member Author

@prestwich thinking too far ahead :) This is fine for now.

@DaniPopes DaniPopes merged commit 89764b7 into main Aug 23, 2023
18 checks passed
@DaniPopes DaniPopes deleted the dani/abi2sol branch August 23, 2023 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants