Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port ethabi json tests #232

Merged
merged 15 commits into from
Aug 23, 2023
Merged

Conversation

mouseless0x
Copy link
Contributor

@mouseless0x mouseless0x commented Aug 16, 2023

Motivation

Port the JSON tests from ethabi to evaluate the json-abi crate in Alloy. (Addresses #103)

Solution

Tests ported over from ethabi:

PR Checklist

  • Added Tests
  • Added Documentation
  • Breaking changes

Copy link
Member

@DaniPopes DaniPopes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, just a nit

crates/json-abi/tests/abi_item_test.rs Outdated Show resolved Hide resolved
Copy link
Contributor Author

@mouseless0x mouseless0x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

commented out sanitize tests have been removed

Copy link
Member

@DaniPopes DaniPopes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@DaniPopes DaniPopes merged commit 112582d into alloy-rs:main Aug 23, 2023
18 checks passed
@mouseless0x mouseless0x deleted the port-ethabi-json-tests branch August 23, 2023 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants