fix(json-abi): properly handle Param type field
#233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DaniPopes
commented
Aug 20, 2023
prestwich
reviewed
Aug 21, 2023
| @@ -184,6 +180,12 @@ impl Param { | |||
| s.push_str(&self.ty) | |||
| } else { | |||
| crate::utils::signature_raw("", &self.components, s); | |||
| // checked during deserialization, but might be invalid from a user | |||
There was a problem hiding this comment.
could we check this on type-instantiation so it's impossible for a user to construct an invalid one?
There was a problem hiding this comment.
How? All struct fields are public
There was a problem hiding this comment.
if public fields allow the user to create invalid instances, then we should at least consider making them non-public
prestwich
approved these changes
Aug 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
typeis either:componentsis not emptycomponentsis emptyCheck this during deserialization and signature formatting.
Added benchmark for signature formatting:
Solution
PR Checklist