Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(dyn-abi): implement more ext traits for json-abi #243

Merged
merged 6 commits into from
Aug 30, 2023
Merged

feat(dyn-abi): implement more ext traits for json-abi #243

merged 6 commits into from
Aug 30, 2023

Conversation

DaniPopes
Copy link
Member

@DaniPopes DaniPopes commented Aug 23, 2023 •
edited
Loading

Motivation

Addresses #210. Follow-up to #227.

Solution

  • JsonAbiExt, implemented for Constructor, Error, Function
  • FunctionExt, implemented for Function
  • new error variants; reduce size of error types

PR Checklist

  • Added Tests
  • Added Documentation
  • Breaking changes

@DaniPopes DaniPopes mentioned this pull request Aug 28, 2023
Merged
3 tasks
@DaniPopes DaniPopes merged commit c06e690 into main Aug 30, 2023
18 checks passed
@DaniPopes DaniPopes deleted the dani/json-ext branch August 30, 2023 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prestwich prestwich prestwich approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DaniPopes @prestwich