Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: struct eip712_data_word #258

Merged
merged 2 commits into from
Aug 31, 2023
Merged

fix: struct eip712_data_word #258

merged 2 commits into from
Aug 31, 2023

Conversation

prestwich
Copy link
Member

Motivation

Close #257

Solution

Remove extra keccak, add test

PR Checklist

  • Added Tests
  • Added Documentation
  • Breaking changes

@prestwich prestwich added the bug Something isn't working label Aug 31, 2023
@prestwich prestwich self-assigned this Aug 31, 2023
@prestwich prestwich mentioned this pull request Aug 31, 2023
Closed
@DaniPopes DaniPopes changed the title Prestwich/eip712 word fix fix: struct eip712_data_word Aug 31, 2023
@DaniPopes DaniPopes merged commit d9d0ded into main Aug 31, 2023
18 checks passed
@DaniPopes DaniPopes deleted the prestwich/eip712-word-fix branch August 31, 2023 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DaniPopes DaniPopes DaniPopes approved these changes

Assignees

@prestwich prestwich

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] Nested structs not hashed correctly
2 participants
@prestwich @DaniPopes