Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: rename coding functions #274

Merged
merged 1 commit into from
Sep 21, 2023
Merged

chore: rename coding functions #274

merged 1 commit into from
Sep 21, 2023

Conversation

DaniPopes
Copy link
Member

@DaniPopes DaniPopes commented Sep 19, 2023

Motivation

More intuitive

Solution

  • {encode,decode} -> {encode,decode}_sequence
  • {encode,decode}_single -> {encode,decode}

PR Checklist

  • Added Tests
  • Added Documentation
  • Breaking changes

@DaniPopes DaniPopes force-pushed the dani/rename-coding-fns branch 4 times, most recently from fe6cd5e to 870d02d Compare September 19, 2023 19:06
gakonst
gakonst previously approved these changes Sep 20, 2023
Copy link
Member

@gakonst gakonst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok w me pending conflicts

@prestwich
Copy link
Member

dont merge until we have a migration comms plan

@prestwich prestwich dismissed gakonst’s stale review September 20, 2023 00:58

dismissing review to prevent merge

Copy link
Member

@prestwich prestwich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

before tagging a release we should write a telegram announcement cc @gakonst

@gakonst gakonst merged commit 0c21fcc into main Sep 21, 2023
18 checks passed
@gakonst gakonst deleted the dani/rename-coding-fns branch September 21, 2023 23:36
@gakonst
Copy link
Member

gakonst commented Sep 21, 2023

yup - left a note about it in TG, and we'll re-announce

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants