Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: standard solidity revert & panic #28

Merged
merged 7 commits into from
May 10, 2023
Merged

Conversation

prestwich
Copy link
Member

Provides structs for the standard solidity revert and panic errors

@prestwich prestwich added the enhancement New feature or request label May 10, 2023
@prestwich prestwich self-assigned this May 10, 2023
@prestwich prestwich requested a review from DaniPopes May 10, 2023 15:58
abi/src/sol_types/sol_error.rs Outdated Show resolved Hide resolved
abi/src/sol_types/sol_error.rs Outdated Show resolved Hide resolved
abi/src/sol_types/sol_error.rs Outdated Show resolved Hide resolved
abi/src/sol_types/sol_error.rs Show resolved Hide resolved
abi/src/sol_types/sol_error.rs Outdated Show resolved Hide resolved
abi/src/sol_types/sol_error.rs Show resolved Hide resolved
abi/src/sol_types/sol_error.rs Outdated Show resolved Hide resolved
abi/src/sol_types/sol_error.rs Outdated Show resolved Hide resolved
abi/src/sol_types/sol_error.rs Outdated Show resolved Hide resolved
abi/src/sol_types/sol_error.rs Outdated Show resolved Hide resolved
abi/src/sol_types/sol_error.rs Outdated Show resolved Hide resolved
Copy link
Member

@DaniPopes DaniPopes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, maybe some basic encoding + verify selector tests?

@prestwich
Copy link
Member Author

adding tests

@DaniPopes DaniPopes merged commit fcaa469 into main May 10, 2023
@DaniPopes DaniPopes deleted the prestwich/revert branch May 15, 2023 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants