Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: rewrite type parser with winnow #292

Merged
merged 4 commits into from
Sep 23, 2023
Merged

Conversation

DaniPopes
Copy link
Member

@DaniPopes DaniPopes commented Sep 22, 2023

Motivation

Easier to expand in the future.

Performance is slightly better, but most of this is probably because of dropped white space support:

parse/keywords          time:   [43.696 ns 43.795 ns 43.931 ns]                           
                        change: [-10.604% -10.130% -9.6426%] (p = 0.00 < 0.05)
                        Performance has improved.
parse/complex           time:   [1.3464 µs 1.3520 µs 1.3588 µs]                           
                        change: [-34.803% -34.511% -34.196%] (p = 0.00 < 0.05)
                        Performance has improved.

Solution

PR Checklist

  • Added Tests
  • Added Documentation
  • Breaking changes

Copy link
Member

@prestwich prestwich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

much much cleaner

@DaniPopes DaniPopes merged commit 3736d33 into main Sep 23, 2023
18 checks passed
@DaniPopes DaniPopes deleted the dani/better-parser branch September 23, 2023 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants