Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature: unsupported message for $idents #293

Merged
merged 1 commit into from
Sep 23, 2023
Merged

feature: unsupported message for $idents #293

merged 1 commit into from
Sep 23, 2023

Conversation

prestwich
Copy link
Member

Adds a simple error message for $-prefixed solidity idents.

Motivation

supplement #288

Solution

Peek for $, return an error string

This solution does not catch idents with $ in non-leading positions. But should help most users

PR Checklist

  • Added Tests
  • Added Documentation
  • Breaking changes

@prestwich prestwich added the enhancement New feature or request label Sep 23, 2023
@prestwich prestwich self-assigned this Sep 23, 2023
@DaniPopes DaniPopes merged commit 91ca63c into main Sep 23, 2023
18 checks passed
@DaniPopes DaniPopes deleted the prestwich/dollar-error branch September 23, 2023 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DaniPopes DaniPopes DaniPopes approved these changes

Assignees

@prestwich prestwich

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@prestwich @DaniPopes