feat(sol-macro): improve type expansion #302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DaniPopes
force-pushed
the
dani/sol-rust-types
branch
2 times, most recently
from
704940e
to
7fd2520
Compare
DaniPopes
force-pushed
the
dani/sol-rust-types
branch
from
c0bbd30
to
571f52f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve docs and LSP support by expanding types to the actual Rust type instead of
<#ty as SolType>::RustTypewhere possibleMy end goal was to be able to hover over
uint256,addressetc and have its Rust definition pop up, but this doesn't work everywhere due to rust analyzer limitationsDepends on #301