test: move decode_revert_reason
to alloy and add tests
#308
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to paradigmxyz/reth#4789
I moved
decode_revert_reason
function here and also add tests:out.len() < Selector::len_bytes()
Actually the last test makes me wonder if it is ok to put that
if
sentence in the first line of the function as it could happen that a vyper revert reason is actually shorter than 4 bytes but still valid.Let me know WDYT.
Also, before I can delete this function from Reth, this PR needs to be merged. Otherwise in Reth there are errors because
decode_revert_reason
does not have any definition.