Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: serde rename resolver to types #335

Merged
merged 3 commits into from
Oct 5, 2023
Merged

fix: serde rename resolver to types #335

merged 3 commits into from
Oct 5, 2023

Conversation

prestwich
Copy link
Member

Motivation

Closes #334

Solution

Add rename to serde derive, and add a test for round-trip serialization

PR Checklist

  • Added Tests
  • Added Documentation
  • Breaking changes

@prestwich prestwich added the bug Something isn't working label Oct 5, 2023
@prestwich prestwich self-assigned this Oct 5, 2023
@prestwich prestwich changed the title fix: rename resolver to types fix: serde rename resolver to types Oct 5, 2023
@prestwich prestwich mentioned this pull request Oct 5, 2023
Closed
@prestwich prestwich merged commit fcb9061 into main Oct 5, 2023
20 checks passed
@DaniPopes DaniPopes deleted the prestwich/712-name-fix branch October 5, 2023 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DaniPopes DaniPopes DaniPopes approved these changes

Assignees

@prestwich prestwich

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

EIP-712 compatible Serializable impl for dyn_abi::eip712::TypedData
2 participants
@prestwich @DaniPopes