Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(sol-macro): correct TypeArray::is_abi_dynamic #353

Merged
merged 1 commit into from
Oct 9, 2023
Merged

fix(sol-macro): correct TypeArray::is_abi_dynamic #353

merged 1 commit into from
Oct 9, 2023

Conversation

DaniPopes
Copy link
Member

Motivation

Fixes #352

Solution

TypeArray::is_abi_dynamic

  • if the array is not dynamic, return Type::is_abi_dynamic
  • if the array is dynamic, return true

PR Checklist

  • Added Tests
  • Added Documentation
  • Breaking changes

@DaniPopes DaniPopes merged commit 9295e7e into main Oct 9, 2023
20 checks passed
@DaniPopes DaniPopes deleted the dani/event-word-dynarray branch October 9, 2023 03:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prestwich prestwich prestwich approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] type mismatch resolving <Array<Uint<256>> as SolType>::TokenType<'_> == WordToken
2 participants
@DaniPopes @prestwich