Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: don't use directory symlinks #394

Merged
merged 1 commit into from
Nov 1, 2023
Merged

fix: don't use directory symlinks #394

merged 1 commit into from
Nov 1, 2023

Conversation

DaniPopes
Copy link
Member

Motivation

Doesn't work on Windows

Solution

PR Checklist

  • Added Tests
  • Added Documentation
  • Breaking changes

mattsse
mattsse approved these changes Nov 1, 2023
View reviewed changes
Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fking symlinks

@DaniPopes
Copy link
Member Author

DaniPopes commented Nov 1, 2023 •
edited
Loading

More like fucking windows

@DaniPopes DaniPopes merged commit a85e404 into main Nov 1, 2023
19 of 20 checks passed
@DaniPopes DaniPopes deleted the dani/fix-dir-symlink branch November 1, 2023 19:08
DaniPopes added a commit that referenced this pull request Nov 1, 2023
@DaniPopes
Revert "fix: don't use directory symlinks (#394)"
fe1b921 
This reverts commit a85e404.
DaniPopes added a commit that referenced this pull request Nov 1, 2023
@DaniPopes
fix: avoid symlinks (#396)
919a338 
* Revert "fix: don't use directory symlinks (#394)"

This reverts commit a85e404.

* fix: impl_core symlink

* fix: sol macro doctest symlinks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

@prestwich prestwich Awaiting requested review from prestwich

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DaniPopes @mattsse