Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Added Hash to DynSolType and StructProp #411

Merged
merged 3 commits into from
Nov 14, 2023
Merged

feat: Added Hash to DynSolType and StructProp #411

merged 3 commits into from
Nov 14, 2023

Conversation

NianSol
Copy link
Contributor

@NianSol NianSol commented Nov 14, 2023 •
edited
Loading

I saw the open issue #402 and decided to implement it

Solution

Simply added hash to the structs and tests to make sure nothing broke

PR Checklist

  • [] Added Tests - No, it's a default crate feature
  • [?] Added Documentation - Not sure if there was a need
  • [] Breaking changes - No

DaniPopes
DaniPopes requested changes Nov 14, 2023
View reviewed changes
crates/dyn-abi/src/ty.rs Outdated Show resolved Hide resolved
@NianSol NianSol closed this Nov 14, 2023
@NianSol NianSol reopened this Nov 14, 2023
DaniPopes
DaniPopes approved these changes Nov 14, 2023
View reviewed changes
Copy link
Member

@DaniPopes DaniPopes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@DaniPopes DaniPopes merged commit f42a068 into alloy-rs:main Nov 14, 2023
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DaniPopes DaniPopes DaniPopes approved these changes

@prestwich prestwich Awaiting requested review from prestwich

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NianSol @DaniPopes