Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(primitives): left and right padding conversions #424

Merged
merged 3 commits into from
Nov 23, 2023
Merged

feat(primitives): left and right padding conversions #424

merged 3 commits into from
Nov 23, 2023

Conversation

prestwich
Copy link
Member

Motivation

Current try_from and from_slice requires exact length. These convenience functions provide variants that support shorter slices by left- or right-padding to the correct length

PR Checklist

  • Added Tests
  • Added Documentation
  • Breaking changes

@prestwich prestwich added the enhancement New feature or request label Nov 20, 2023
@prestwich prestwich self-assigned this Nov 20, 2023
@prestwich prestwich marked this pull request as ready for review November 20, 2023 17:05
@DaniPopes DaniPopes changed the title feature: left and right padding from for fixed feat(primitives): left and right padding conversions Nov 23, 2023
@DaniPopes DaniPopes merged commit 07fe0fc into main Nov 23, 2023
20 checks passed
@DaniPopes DaniPopes deleted the prestwich/pad-slice branch November 23, 2023 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DaniPopes DaniPopes DaniPopes requested changes

Assignees

@prestwich prestwich

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@prestwich @DaniPopes