Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(primitives): improve utils #432

Merged
merged 6 commits into from
Nov 23, 2023
Merged

feat(primitives): improve utils #432

merged 6 commits into from
Nov 23, 2023
+955 −111

Conversation

DaniPopes
Copy link
Member

@DaniPopes DaniPopes commented Nov 23, 2023 •
edited
Loading

Motivation

Improve existing and add new utilities. Mostly the units utilities from ethers-core.

Solution

PR Checklist

  • Added Tests
  • Added Documentation
  • Breaking changes

mattsse
mattsse approved these changes Nov 23, 2023
View reviewed changes
Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

crates/primitives/src/utils/mod.rs Show resolved Hide resolved
@DaniPopes DaniPopes merged commit 7062c0c into main Nov 23, 2023
20 checks passed
@DaniPopes DaniPopes deleted the dani/better-primitive-utils branch November 23, 2023 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Evalir Evalir Evalir approved these changes

@mattsse mattsse mattsse approved these changes

@prestwich prestwich Awaiting requested review from prestwich

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DaniPopes @mattsse @Evalir