feat(primitives): update Bytes formatting, add UpperHex #446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattsse
approved these changes
Dec 5, 2023
prestwich
reviewed
Dec 5, 2023
| } | ||
| } | ||
|
|
||
| impl fmt::LowerHex for Bytes { | ||
| fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result { | ||
| f.write_str(&self.hex_encode()) | ||
| f.pad(&hex::encode_prefixed(self.as_ref())) |
There was a problem hiding this comment.
we should match std behavior here by adding 0x only when fmt.alternate() is true
There was a problem hiding this comment.
(as a drive-by while we're touching this code)
There was a problem hiding this comment.
I'll open a new PR for this
DaniPopes
force-pushed
the
dani/bytes-fmt
branch
from
f31dce2
to
5dcd4f2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Don't print "Bytes()" in Debug
Solution
PR Checklist