Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ToSql and FromSql to Signed and FixedBytes #447

Merged
merged 7 commits into from
Dec 18, 2023
Merged

Add ToSql and FromSql to Signed and FixedBytes #447

merged 7 commits into from
Dec 18, 2023

Conversation

hhamud
Copy link
Contributor

@hhamud hhamud commented Dec 8, 2023 •
edited by DaniPopes
Loading

Motivation

Changes made as requested according to this issue #365

Closes #365

Solution

Applying toSql and FromSql traits from Postgres_types package to FixedBytes and Signed Type.

PR Checklist

  • Added Tests
  • Added Documentation
  • Breaking changes

@prestwich
Copy link
Member

approving workflow to run. Before consideration for merge the following changes will need to be made

  • postgres dependency set to optional = true
  • postgres feature, with postgres = ["dep:postgres-types"]
  • postgres mod set to #[cfg(feature = "postgres")]

@hhamud hhamud marked this pull request as ready for review December 16, 2023 00:43
@DaniPopes DaniPopes merged commit 6c32c9b into alloy-rs:main Dec 18, 2023
20 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DaniPopes DaniPopes Awaiting requested review from DaniPopes DaniPopes is a code owner

@prestwich prestwich Awaiting requested review from prestwich

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature] Implement ToSql and FromSql traits from postgres types for ethereum specific types
3 participants
@hhamud @prestwich @DaniPopes