fix: don't decode ZSTs #454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DaniPopes
force-pushed
the
prestwich/dos-prevention
branch
from
dd4dec9
to
7fc4059
Compare
DaniPopes
approved these changes
Dec 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Closes #392
Fix here prevents zero-sized types from adding significant overhead to decoding, this is an alternative to the proposed fix of disabling instantiation of ZSTs.
DynSolTypehas many instantiation vectors, and we may not be able to effectively prevent incorrect use of all of them.Followup: research whether we can do this effectively
Solution
Add an
is_zstcheck to decoding, which short-circuits decoding of zero-sized values.PR Checklist