Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(primitives): add Signature type and utils #459

Merged
merged 20 commits into from
Jan 4, 2024
Merged

feat(primitives): add Signature type and utils #459

merged 20 commits into from
Jan 4, 2024

Conversation

prestwich
Copy link
Member

Motivation

Add a primitive Signature type to support ongoing work in alloy transaction models

Solution

  • Add Signature to primitives crate
  • Add k256 feature
  • Add Address::from_public_key convenience function

PR Checklist

  • Added Tests
  • Added Documentation
  • Breaking changes

@prestwich prestwich added the enhancement New feature or request label Dec 18, 2023
@prestwich prestwich self-assigned this Dec 18, 2023
@prestwich
Copy link
Member Author

CI failure is a new clippy lint, unrelated to this work

DaniPopes
DaniPopes requested changes Dec 18, 2023
View reviewed changes
Copy link
Member

@DaniPopes DaniPopes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly OK, might need to port from the other PR.

crates/primitives/src/signature.rs Outdated Show resolved Hide resolved
crates/primitives/src/signature.rs Outdated Show resolved Hide resolved
crates/primitives/src/signature.rs Outdated Show resolved Hide resolved
crates/primitives/src/signature.rs Outdated Show resolved Hide resolved
crates/primitives/src/signature.rs Outdated Show resolved Hide resolved
@prestwich prestwich mentioned this pull request Dec 24, 2023
Closed
2 tasks
DaniPopes
DaniPopes requested changes Dec 28, 2023
View reviewed changes
crates/primitives/src/signature/parity.rs Show resolved Hide resolved
crates/primitives/src/signature/sig.rs Show resolved Hide resolved
crates/primitives/src/signature/sig.rs Show resolved Hide resolved
crates/primitives/src/signature/sig.rs Show resolved Hide resolved
@DaniPopes DaniPopes changed the title feature: Signature feat(primitives): add Signature type and utils Dec 28, 2023
DaniPopes
DaniPopes approved these changes Dec 28, 2023
View reviewed changes
crates/primitives/src/bits/address.rs Outdated Show resolved Hide resolved
DaniPopes
DaniPopes requested changes Jan 4, 2024
View reviewed changes
crates/primitives/src/bits/address.rs Outdated Show resolved Hide resolved
@DaniPopes DaniPopes merged commit b2a09f2 into main Jan 4, 2024
21 checks passed
@DaniPopes DaniPopes deleted the prestwich/signature-primitive branch January 4, 2024 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DaniPopes DaniPopes DaniPopes approved these changes

Assignees

@prestwich prestwich

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@prestwich @DaniPopes