Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Log implementation #465

Merged
merged 5 commits into from
Dec 28, 2023
Merged

refactor: Log implementation #465

merged 5 commits into from
Dec 28, 2023

Conversation

prestwich
Copy link
Member

@prestwich prestwich commented Dec 25, 2023 •
edited by DaniPopes
Loading

CC @Evalir @DaniPopes

Motivation

Refactors log to support address and raw/decoded data

Solution

  • rename Log to LogData
  • make Log<T = LogData>
  • modify SolEvent and SolEventInterface to decode into Log<Self>
  • rename functions for added clarity
  • implement RLP on Log (needs testing)
  • expand Bloom with FromIterator and Extend, and specialized contains methods for logs

PR Checklist

  • Added Tests
  • Added Documentation
  • Breaking changes

@prestwich prestwich added the enhancement New feature or request label Dec 25, 2023
@prestwich prestwich self-assigned this Dec 25, 2023
@DaniPopes DaniPopes changed the title Log Refactor refactor: Log implementation Dec 28, 2023
@prestwich prestwich merged commit ae594c7 into main Dec 28, 2023
21 checks passed
@prestwich prestwich deleted the prestwich/new-log branch December 28, 2023 00:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DaniPopes DaniPopes DaniPopes approved these changes

Assignees

@prestwich prestwich

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@prestwich @DaniPopes