perf: add optional support for keccak-asm #466
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Closes #414
See https://github.com/DaniPopes/keccak-asm, https://github.com/DaniPopes/bench-keccak256
Solution
Add
"asm-keccak"
feature which overrides the tiny-keccak implementation withkeccak-asm
Benches
https://github.com/DaniPopes/bench-keccak256
Local:
RUSTFLAGS=""
2.60-2.75 µs -> 2.10-2.20 µs
RUSTFLAGS="-Ctarget-cpu=native" (AVX512VL)
2.08-2.20 µs -> 2.04-2.10 µs
PR Checklist